Skip to content

Clarify hotpatch rollback instructions#13415

Merged
lecoursen merged 5 commits intogithub:mainfrom
ThatStoney:patch-2
Jan 6, 2022
Merged

Clarify hotpatch rollback instructions#13415
lecoursen merged 5 commits intogithub:mainfrom
ThatStoney:patch-2

Conversation

@ThatStoney
Copy link
Copy Markdown
Member

@ThatStoney ThatStoney commented Dec 27, 2021

Replication does not need to be stopped before hotpatching, so most customers faced with a rollback will probably have replication running. Since replication can't be running for a package upgrade (which is how we roll back a hotpatch) we should include a reminder in our docs that replication will need to be stopped prior to rolling back.

Why:

Closes https://github.com/github/docs-content/issues/5897

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@ThatStoney
Clarify hotpatch rollback instructions
fd3e81c 
Replication does not need to be stopped before hotpatching, so most customers faced with a rollback will probably have replication running. Since replication can't be running for a package upgrade (which is how we roll back a hotpatch) we should include a reminder in our docs that replication will need to be stopped prior to rolling back.
@welcome
Copy link
Copy Markdown

welcome bot commented Dec 27, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 27, 2021 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/admin/enterprise-management/updating-the-virtual-machine-and-physical-resources/upgrading-github-enterprise-server.md Modified Original

@ramyaparimi ramyaparimi added enterprise Content relating to GitHub Enterprise content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Dec 27, 2021
vgrl
vgrl previously approved these changes Jan 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@vgrl vgrl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ✨ Looks great! Just a quick fix and minor suggestion and then this PR is good to go.

When you're ready for these changes to be published, just ask the team in #docs-content to merge this PR.

Comment thread ...nt/updating-the-virtual-machine-and-physical-resources/upgrading-github-enterprise-server.md Outdated
Comment thread ...nt/updating-the-virtual-machine-and-physical-resources/upgrading-github-enterprise-server.md Outdated
@github-actions github-actions bot temporarily deployed to docs-13415--patch-2 January 6, 2022 00:59 Inactive
@lecoursen @vgrl
Apply @vgrl's suggestions
f1b7abe 
Co-authored-by: Vanessa <vgrl@github.com>
@github-actions github-actions bot temporarily deployed to docs-13415--patch-2 January 6, 2022 17:52 Inactive
@lecoursen
Copy link
Copy Markdown
Member

lecoursen commented Jan 6, 2022

I'll go ahead and merge this now!

@lecoursen lecoursen enabled auto-merge January 6, 2022 18:03
@github-actions github-actions bot temporarily deployed to docs-13415--patch-2 January 6, 2022 18:08 Inactive
@lecoursen lecoursen merged commit d8a51f2 into github:main Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lecoursen lecoursen lecoursen approved these changes

@vgrl vgrl vgrl left review comments

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team enterprise Content relating to GitHub Enterprise waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ThatStoney @lecoursen @vgrl @myarb @ramyaparimi